Skip to content

linalg: slightly increase test tolerance #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

perazz
Copy link
Member

@perazz perazz commented Apr 22, 2025

this PR attempts to fix some CI failures by relaxing the pinv (pseudoinverse) test tolerance.
pinv works with singular matrices and the accuracy of the inverse in the test may be affected by the random number choice.

@perazz perazz requested a review from jvdp1 April 22, 2025 16:37
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @perazz

@perazz
Copy link
Member Author

perazz commented Apr 27, 2025

Thank you for the review @jvdp1: because this is a short PR, I will go ahead and merge.

@perazz perazz merged commit c14d599 into fortran-lang:master Apr 27, 2025
14 checks passed
@perazz perazz deleted the pinv_test_tol branch April 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants